Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Iron support #289

Merged
merged 2 commits into from
Nov 6, 2021
Merged

Remove Iron support #289

merged 2 commits into from
Nov 6, 2021

Conversation

lambda-fairy
Copy link
Owner

@lambda-fairy lambda-fairy commented Sep 4, 2021

The Iron framework hasn't been updated in a long time. It still uses outdated versions of libraries like futures 0.1, hyper 0.12, url 1.7. We can clean up the repo by removing it. This will also slightly speed up CI.

@lambda-fairy lambda-fairy force-pushed the no-iron branch 2 times, most recently from dd51cfe to 073da05 Compare September 18, 2021 08:35
@lambda-fairy
Copy link
Owner Author

lambda-fairy commented Sep 18, 2021

Benchmarked with cargo clean; time cargo build --tests -j2, run 3 times each

  • Old: 3m36s
  • New: 3m30s

(No, I didn't just copy the results from #292 – they really do have the same effect on compile times 🤔)

@lambda-fairy lambda-fairy force-pushed the no-iron branch 2 times, most recently from a850d00 to 6bb8d02 Compare September 19, 2021 07:21
@lambda-fairy lambda-fairy added this to the 1.0 milestone Sep 27, 2021
The Iron framework hasn't been updated in a long time. It still uses outdated versions of libraries like futures 0.1, hyper 0.12, url 1.7. We can speed up CI by removing it.
@lambda-fairy
Copy link
Owner Author

Two months and no-one's complained. Let's land this.

@lambda-fairy lambda-fairy enabled auto-merge (squash) November 6, 2021 11:41
@lambda-fairy lambda-fairy merged commit 434af86 into main Nov 6, 2021
@lambda-fairy lambda-fairy deleted the no-iron branch November 6, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant